ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 25581: Config History: capacity-scheduler properties from service_config_version should be in same order as before
Date Fri, 12 Sep 2014 14:26:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25581/#review53174
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Sept. 12, 2014, 2:25 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25581/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2014, 2:25 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-7279
>     https://issues.apache.org/jira/browse/AMBARI-7279
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> From API
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c123/configurations/service_config_versions?service_name=YARN&service_config_version=8
> The capacity-scheduler properties are:
> "Config" : {
>             "cluster_name" : "c123"
>           },
>           "type" : "capacity-scheduler",
>           "tag" : "version1409783371662",
>           "version" : 2,
>           "properties" : {
>             "yarn.scheduler.capacity.root.default.acl_administer_jobs" : "*",
>             "yarn.scheduler.capacity.root.queues" : "default",
>             "yarn.scheduler.capacity.node-locality-delay" : "40",
>             "yarn.scheduler.capacity.root.default.maximum-capacity" : "100",
>             "yarn.scheduler.capacity.maximum-am-resource-percent" : "0.2",
>             "yarn.scheduler.capacity.root.default.acl_submit_applications" : "*",
>             "yarn.scheduler.capacity.root.default.state" : "RUNNING",
>             "yarn.scheduler.capacity.root.acl_administer_queue" : "*",
>             "yarn.scheduler.capacity.maximum-applications" : "10006",
>             "yarn.scheduler.capacity.root.default.capacity" : "100",
>             "yarn.scheduler.capacity.root.default.user-limit-factor" : "1",
>             "yarn.scheduler.capacity.root.capacity" : "100"
>           },
>           "properties_attributes" : { }
> However, the properties we get from
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c123/configurations?type=capacity-scheduler&tag=version1409783371662
> are:
> "href" : "http://c6401.ambari.apache.org:8080/api/v1/clusters/c123/configurations?type=capacity-scheduler&tag=version1409783371662",
>       "tag" : "version1409783371662",
>       "type" : "capacity-scheduler",
>       "version" : 2,
>       "Config" : {
>         "cluster_name" : "c123"
>       },
>       "properties" : {
>         "yarn.scheduler.capacity.maximum-am-resource-percent" : "0.2",
>         "yarn.scheduler.capacity.maximum-applications" : "10006",
>         "yarn.scheduler.capacity.node-locality-delay" : "40",
>         "yarn.scheduler.capacity.root.acl_administer_queue" : "*",
>         "yarn.scheduler.capacity.root.capacity" : "100",
>         "yarn.scheduler.capacity.root.default.acl_administer_jobs" : "*",
>         "yarn.scheduler.capacity.root.default.acl_submit_applications" : "*",
>         "yarn.scheduler.capacity.root.default.capacity" : "100",
>         "yarn.scheduler.capacity.root.default.maximum-capacity" : "100",
>         "yarn.scheduler.capacity.root.default.state" : "RUNNING",
>         "yarn.scheduler.capacity.root.default.user-limit-factor" : "1",
>         "yarn.scheduler.capacity.root.queues" : "default"
>       }
> Notice that the order of properties are different though the property values are the
same.
> This issue will a FE issue as attached. 
> (the light blue highlight meaning, in current compare view, capacity-scheduler are different
in the two versions. However, each value is the same, the only difference is the sorting of
properties.)
> Expected results:
> from
> /configurations/service_config_versions?service_name=YARN&service_config_version=8
> , we should get the properties in the same order as
> /configurations?type=capacity-scheduler&tag=version14..
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java
f284030 
> 
> Diff: https://reviews.apache.org/r/25581/diff/
> 
> 
> Testing
> -------
> 
> all unit tests passed.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message