ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 25542: Alerts: DDL for alert_current requires latest_text
Date Thu, 11 Sep 2014 18:28:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25542/#review53080
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
<https://reviews.apache.org/r/25542/#comment92476>

    On upgrade, latest_text should be marked as nullable to match the DDL.


- Jonathan Hurley


On Sept. 11, 2014, 12:08 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25542/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 12:08 p.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-7263
>     https://issues.apache.org/jira/browse/AMBARI-7263
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need the latest_text on a current record, as that data may have the latest-and-greatest
coming from an agent, even though there would be no new history record.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java
cde61f2 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
17750f9 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 356ef0c 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ecaf220 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f0ac53a 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 6e82ae1 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
d3d7f7c 
> 
> Diff: https://reviews.apache.org/r/25542/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:41.861s
> [INFO] Finished at: Thu Sep 11 12:01:26 EDT 2014
> [INFO] Final Memory: 21M/219M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message