ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 25498: No start action for stopped service in MM mode Stack 1.3
Date Wed, 10 Sep 2014 15:27:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25498/
-----------------------------------------------------------

(Updated Sept. 10, 2014, 3:27 p.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-7237
    https://issues.apache.org/jira/browse/AMBARI-7237


Repository: ambari


Description
-------

On stack 1.3 stop service, then put it into MM. Try to open Service Actions menu - start option
is inactive.
Here is how service state calculation worked: if component is in MM, we don't take it's state
into account when calculating entire service state. At the extreme case when all components
of a service are in MM, we return DISABLED state for the service.
To fix the current jira, I've implemented a special handling for the case when all service
components (or entire service) are in MM as follows:
we iterate over all master & slave componens and determine the best component state (e.g.
INSTALLED -> STARTED)
now the best state for MM component becomes a calculated state for an entire service
That means that if all components of service are in MM and at least one component is started,
entire service will be showed as started.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
aec91fd 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
7dbc38b 

Diff: https://reviews.apache.org/r/25498/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [2.697s]
[INFO] Ambari Server ..................................... SUCCESS [17:29.054s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:32.360s
[INFO] Finished at: Wed Sep 10 18:18:55 FET 2014
[INFO] Final Memory: 23M/252M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message