ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 25480: Views : support for a <system> property
Date Wed, 10 Sep 2014 04:14:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25480/#review52817
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
<https://reviews.apache.org/r/25480/#comment91989>

    Was there a reason that you chose to make this a character? The other entities that need
to represent a boolean use a SMALLINT.


- Jonathan Hurley


On Sept. 9, 2014, 2 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25480/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 2 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: Ambari-7211
>     https://issues.apache.org/jira/browse/Ambari-7211
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1 Add support for a <system> property in view.xml, which means the view is a system
view and restricted to only admin access
> 2 Set <system>true</system> in the Admin View view.xml
> 3 The Admin View UI will recognize this property and totally hide the view (and it's
instances) from the Admin View UI (i.e. it will not be shown on the Views section of the Admin
View to avoid confusion).
> 4 The view API will disable creating instances or setting privileges for any view with
this prop.
> 
> So end result: views that are system are meant to be AMBARI.ADMIN only and have their
instances statically defined. The first usage of this is the ADMIN_VIEW.
> 
> We might have to evolve this over time but think this would solve more than a few problems
we are having with the fact Admin View is a view.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java
d7c6a8f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java
ed9f06a 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java 073451d

>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
801249f 
>   ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
816c178 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 59d972e 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 52ca857 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 39d3ecf 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 196d298 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
fbeb0cc 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java
977e01d 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
9668ed5 
>   ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
2ed365e 
> 
> Diff: https://reviews.apache.org/r/25480/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> New unit tests added.  All pass ...
> 
> Results :
> 
> Tests run: 1975, Failures: 0, Errors: 0, Skipped: 16
> 
> ...
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 41:21.741s
> [INFO] Finished at: Tue Sep 09 13:47:17 EDT 2014
> [INFO] Final Memory: 45M/421M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message