ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 25362: Alerts: add endpoints for alert data
Date Sun, 07 Sep 2014 10:41:59 GMT


> On Sept. 6, 2014, 3:43 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertService.java,
line 38
> > <https://reviews.apache.org/r/25362/diff/1/?file=679058#file679058line38>
> >
> >     This service is for alerts off of a cluster; we could potentially have cross-cluster
alert data in the future. Would it be better to name this ClusterAlertService?

It's for data, and the requirement of cluster is already addressed.  Since the endpoint is
across clusters, services, and hosts, only one actual class is needed.


> On Sept. 6, 2014, 3:43 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertService.java,
line 55
> > <https://reviews.apache.org/r/25362/diff/1/?file=679058#file679058line55>
> >
> >     Copy/Paste error? The methods in this class return alert data, not definitions?

Will address next patch.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25362/#review52545
-----------------------------------------------------------


On Sept. 4, 2014, 7:49 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25362/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 7:49 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Tom Beerbower.
> 
> 
> Bugs: AMBARI-7160
>     https://issues.apache.org/jira/browse/AMBARI-7160
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Initial cut at creating endpoints for alert data at cluster, service, and host level.
> * Names are not the final ones, that will be in a separate jira (we have an attribute
already called 'alerts' - those are out of Nagios)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
702bcf8 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java
8aba287 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
ffbfb29 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java
e1355ad 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertService.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
3f1ce36 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
db9d3c0 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
643ae36 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c75a7bb

>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
31c350b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 2cf6d99

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java b43b5b1

>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java
31b1673 
>   ambari-server/src/main/resources/key_properties.json db34920 
>   ambari-server/src/main/resources/properties.json accab44 
>   ambari-server/src/test/java/org/apache/ambari/server/api/query/render/DefaultRendererTest.java
eb0f28f 
>   ambari-server/src/test/java/org/apache/ambari/server/api/query/render/MinimalRendererTest.java
16cbb2a 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java
eabb5ab 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 4500c1c

> 
> Diff: https://reviews.apache.org/r/25362/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:30.862s
> [INFO] Finished at: Thu Sep 04 19:14:56 EDT 2014
> [INFO] Final Memory: 26M/218M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message