Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Received-SPF: pass (nike.apache.org: domain of jun.aoki.dev@gmail.com
 designates 209.85.192.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <D008EB01.6CDB%greg.hill@rackspace.com>
References: 
 <CAGjSOKW88TF_iLVhCeCYGRXMva_Zw8uWPbHfip0dRfhfbKVkmA@mail.gmail.com>
	<D008EB01.6CDB%greg.hill@rackspace.com>
Date: Thu, 7 Aug 2014 13:15:38 -0700
Message-ID: 
 <CA+deypEPn8R0R5h5HjWn1SNYK47bA7hohvNWmg7HMX_d+Zjhhw@mail.gmail.com>
Subject: Re: is there a good reason we don't just use github?
From: jun aoki <jun.aoki.dev@gmail.com>
To: dev@ambari.apache.org
Content-Type: multipart/alternative; boundary=001a11c3d4a895081d05000fc0c5

--001a11c3d4a895081d05000fc0c5
Content-Type: text/plain; charset=UTF-8

+1 to Greg's suggestion, it would be also nice to see issues are tracked by
Github instead of Apache Jira.


On Thu, Aug 7, 2014 at 6:48 AM, Greg Hill <greg.hill@rackspace.com> wrote:

>
>
> On 8/6/14 12:24 PM, "Yusaku Sako" <yusaku@hortonworks.com> wrote:
>
>
> >Apache Git and Github integration is a relatively new feature (see
> >[1]) and we haven't really looked into it so far, but it might be
> >nicer to be able to make pull requests on Github, etc., in a more
> >convenient, modern fashion.
>
>
> The github code review tools are just so much better, IMO, and submitting
> a pull-request is a lot nicer than manually creating a patch and uploading
> it to two different systems.
>
> I'd be willing to help beta test things if people who can change things
> want to give it a shot.  Sounds like it won't be as simple as merging the
> pull-request from the committer's perspective, but if I can just open a
> JIRA then submit a pull-request with a comment pointing it at the JIRA
> ticket, that's a much nicer experience for me as a contributor.
>
> >
> >> And people then get credit for their contributions as well, where the
> >>current procedure gives credit only to the committer.
> >
> >As far as non-committers getting credit for their contributions,
> >that's always been the case.  They do get credit on Ambari JIRAs
> >(being the assignee of a JIRA marked "Fixed") as well as in the commit
> >log.
> >Do you mean the code contributions being reflected in the
> >contributors' Github profile and such?
>
> Yes, basically.  Github profiles are becoming basically a developer's
> portfolio, so being publicly credited for their work is an important
> factor to get right.  It also helps for people debugging to be able to use
> git blame to see who they might need to talk to to understand a part of
> code they are having trouble with.
>
> Greg
>
>
>


-- 
-jun

--001a11c3d4a895081d05000fc0c5--