Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 755EF11481 for ; Fri, 22 Aug 2014 13:30:56 +0000 (UTC) Received: (qmail 16920 invoked by uid 500); 22 Aug 2014 13:30:56 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 16892 invoked by uid 500); 22 Aug 2014 13:30:56 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 16867 invoked by uid 99); 22 Aug 2014 13:30:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Aug 2014 13:30:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 82A8E1D98E5; Fri, 22 Aug 2014 13:30:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4665215141864294674==" MIME-Version: 1.0 Subject: Review Request 24979: Alerts: persist and allow configuration substitution variables for alert definitions From: "Nate Cole" To: "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Fri, 22 Aug 2014 13:30:56 -0000 Message-ID: <20140822133056.15059.43834@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/24979/ X-Sender: "Nate Cole" Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============4665215141864294674== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24979/ ----------------------------------------------------------- Review request for Ambari and Jonathan Hurley. Bugs: AMBARI-6983 https://issues.apache.org/jira/browse/AMBARI-6983 Repository: ambari Description ------- * Made some changes from last review - adding constants for source types, save all definitions in one file instead of one-per-cluster. * Added substitution variables for those sources that support it. Diffs ----- ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 10fdef7 ambari-agent/src/main/python/ambari_agent/Controller.py 23c28ae ambari-agent/src/main/python/ambari_agent/Heartbeat.py fb41759 ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 6e99692 ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 2f051c8 ambari-agent/src/test/python/ambari_agent/TestAlerts.py 0d0563a ambari-agent/src/test/python/ambari_agent/TestController.py 9ec23db ambari-agent/src/test/python/ambari_agent/dummy_files/alert_definitions.def 45fb8d0 ambari-agent/src/test/python/ambari_agent/dummy_files/definitions.json PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java 3c9615f ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeat.java 80cad4e ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 65b7b6f ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 5336694 Diff: https://reviews.apache.org/r/24979/diff/ Testing ------- Wanted to get this patch in before being unavailable for a week, so full test suite not made for this patch. Verified existing tests are not broken. [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 5.748s [INFO] Finished at: Fri Aug 22 09:29:41 EDT 2014 [INFO] Final Memory: 7M/81M [INFO] ------------------------------------------------------------------------ Thanks, Nate Cole --===============4665215141864294674==--