Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0DBFE114C3 for ; Mon, 4 Aug 2014 16:27:44 +0000 (UTC) Received: (qmail 4663 invoked by uid 500); 4 Aug 2014 16:27:43 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 4639 invoked by uid 500); 4 Aug 2014 16:27:43 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 4616 invoked by uid 99); 4 Aug 2014 16:27:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Aug 2014 16:27:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E21321D9A6E; Mon, 4 Aug 2014 16:27:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1964639402875018860==" MIME-Version: 1.0 Subject: Re: Review Request 24191: Alerts: Add alert schema tables for Oracle, MySQL, PostgreSQL remote From: "Jonathan Hurley" To: "Sumit Mohanty" , "Sid Wagle" , "Tom Beerbower" Cc: "Ambari" , "Jonathan Hurley" Date: Mon, 04 Aug 2014 16:27:29 -0000 Message-ID: <20140804162729.1587.54409@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/24191/ X-Sender: "Jonathan Hurley" References: <20140801231539.18793.11392@reviews.apache.org> In-Reply-To: <20140801231539.18793.11392@reviews.apache.org> Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============1964639402875018860== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24191/ ----------------------------------------------------------- (Updated Aug. 4, 2014, 12:27 p.m.) Review request for Ambari, Sumit Mohanty, Sid Wagle, and Tom Beerbower. Bugs: AMBARI-6717 https://issues.apache.org/jira/browse/AMBARI-6717 Repository: ambari Description ------- Adds alerting SQL to Oracle and MySQL and also upgrades existing databases. This is required since we defined entities in the persistence.xml, even though alerts aren't shipping for a while. We could have removed the entities from persistence.xml, but then unit tests would start to fail. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java c13b742 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7333919 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 5698c5d ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql dbb55e8 ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 4e0e912 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java e74f257 Diff: https://reviews.apache.org/r/24191/diff/ Testing ------- mvn clean test [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 16:52.179s [INFO] Finished at: Fri Aug 01 16:09:43 EDT 2014 [INFO] Final Memory: 22M/123M [INFO] ------------------------------------------------------------------------ Thanks, Jonathan Hurley --===============1964639402875018860==--