ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 25071: Alerts: Create Group and Target REST Endpoints
Date Wed, 27 Aug 2014 00:15:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25071/
-----------------------------------------------------------

(Updated Aug. 26, 2014, 8:15 p.m.)


Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-7021
    https://issues.apache.org/jira/browse/AMBARI-7021


Repository: ambari


Description
-------

Add the initial REST endpoints for interacting with alert targets and groups. 

Update is not implemented since there's the larger issue of how to tackle generic concepts
like target properties. Also, discussion needs to be around what default data gets returned
in the queries (like targets and definitions) - right now the minimum data is returned.


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 07987d91c19a13c7a582d506945bde607c74bb81

  ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py d06d1f40daeb57a7db848a465382221e765c067c

  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java dca3bd92eedfc08cfd10ffe1056ca32327e12220

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertGroupResourceDefinition.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/AlertTargetResourceDefinition.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
13fff1d5d9d12cc1b0fa3ea62a773005a280e4d9 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertGroupService.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertTargetService.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 8043b3fb567b48eff682d07f978f678099d4ebc2

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 21c9d80732b05c0b09206ceb9578a23a36aa6e14

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
71ddc8d9f6579a05e82536943d25665537558f29 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java b10b4bca27d2a52bd0730f5c3a2380dffcb54ff5

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java 2871e62f92c9767ad7b8006dd552861642896b83

  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertGroup.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertTarget.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/state/alert/TargetType.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
cc5bb5b7fc5d05761f729b2f55f8343da1618d26 
  ambari-server/src/main/resources/key_properties.json 06ebb615d7d5256db432ca012b97608cd948ebe6

  ambari-server/src/main/resources/properties.json bc2ad22691e24e339ad1b7ffe9b1d7bf3dca8306

  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
c0bdaa29a9f8592c306e32b41835cb0f7d819d3c 

Diff: https://reviews.apache.org/r/25071/diff/


Testing
-------


Results :

Tests run: 1945, Failures: 0, Errors: 0, Skipped: 14


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message