ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 24988: Alerts: Populate Alert Definition Table And Agents
Date Fri, 22 Aug 2014 19:28:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24988/#review51309
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Aug. 22, 2014, 3:21 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24988/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2014, 3:21 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-6994
>     https://issues.apache.org/jira/browse/AMBARI-6994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The alert definition table should be populated in the following situations:
> 
> - When starting the Ambari server, the stack services should be merged into the database.
> - When installing a new service, the definitions should be loaded into the database for
that service.
> 
> Note that we needed to expose some of the entity relationships between ClusterEntity
and AlertDefinitionEntity for the unit tests to establish the correct Foreign Keys in Derby.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
7645f73c4515687d351870b80e1d91a01de5d5bb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
ced50ecbb7cf81e93c8bbca0c4c24612d95a31d3 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
583f4bf756c8aa0d9957835057b1d5eac3c0ce95 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
c93702a54ff2dc22d7eec48b15eb687fc799c2b9 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
292a4d3377c62bf47c20632b5a2b6aa5a660e984 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 36aa65feffdda84142d988e0b0b41b68b73c636c

>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
5aa59daaf7df38f8991a0ba84ef2696af0e4ce5c 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java
3a89dd93f5da5776e1c2f919db9f51399721c502 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
baf58e79b45ae2899813d45105031e7211844ea3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
ade579229fe6ec781ab6d7a61351efd7c6a32337 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/alerts.json PRE-CREATION

>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java
d621a9b2f64cc74df7affd1deebd67d59784e839 
> 
> Diff: https://reviews.apache.org/r/24988/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message