ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 24831: Alerts: AlertDefinition Should Have a Label
Date Tue, 19 Aug 2014 02:28:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24831/
-----------------------------------------------------------

(Updated Aug. 18, 2014, 10:28 p.m.)


Review request for Ambari and Nate Cole.


Bugs: AMBARI-6908
    https://issues.apache.org/jira/browse/AMBARI-6908


Repository: ambari


Description
-------

The design documentation (and JSON so far) has a label field for every AlertDefinition. This
label field is really a description of the AlertDefinition. It's a human readable field that
properly identifies the AlertDefintiion but is not unique (like the name).

Example:

     "NAMENODE": [
        {
          "name": "hdfs_capacity_check", // unique name
          "label": "HDFS Capacity Utilization",
    ...

Since this is a DDL change, it's desirable to have this in 1.7.0 since that's where the alert
database model first appears (and prevents the need to write an upgrade for this field).


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
6f00c2788ebe03468da57a611e658ed1ba617af9 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
23ad8f41f7218393d09130ca0c8e632f5d792ba6 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java bef01c14a6abc46a0c1d216531418d2af858b2fb

  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b39ca5d9870d962450e6b6d78a19b2d622cdfd68

  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 500313b1f30a1a18a596a63e41a2aed98ea94a0b

  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql a13f41550cdf403332426a74bf33e54e5fc00510

  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql ff38b2496a617dd7a523d33f49314f00e230e50b

  ambari-server/src/main/resources/properties.json 55b451e84e998125c6f2eb51882c8b06dcb60af0

  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
fc573896de7015ebbc97de0ca1ed13ff7eb4c8ce 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
4033f032d6ce35ecad03bc0d8e9a96638752ac02 

Diff: https://reviews.apache.org/r/24831/diff/


Testing (updated)
-------

mvn clean test

Results :

Tests run: 1934, Failures: 0, Errors: 0, Skipped: 15


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message