ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 24745: Alerts: Send Definitions Down Via Commands to the Agent
Date Fri, 15 Aug 2014 19:13:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24745/
-----------------------------------------------------------

(Updated Aug. 15, 2014, 3:13 p.m.)


Review request for Ambari and Nate Cole.


Changes
-------

Patch with a single test case fixed related to my changes (RB wasn't letting me upload it
before publishing)


Bugs: AMBARI-6880
    https://issues.apache.org/jira/browse/AMBARI-6880


Repository: ambari


Description
-------

Ambari agent hosts will receive the alert definitions they are responsible for scheudling
via a new command type that is pushed down in the following scenarios:

- Agent Registration
- AlertDefinition invalidation

The commands will be present in a heartbeat response if the server has determined that it
thinks the agents need to be made away of which alert definitions are required to be scheduled.
A hash value will also be sent along with the commands so that agents can decide if they do
not need to reschedule their jobs.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/agent/ActionQueue.java 225c7dfe4230f93826f7acbd4ea2cbf7b8efd86f

  ambari-server/src/main/java/org/apache/ambari/server/agent/AgentCommand.java 54faf6a39e35bd19c4e90dff7fd1562d790fef67

  ambari-server/src/main/java/org/apache/ambari/server/agent/AlertDefinitionCommand.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 8a818a6922f25bf88a2b26bf176c59f6192b961b

  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatResponse.java 24bd8a2934787b5c5e64be81fafdc72348f1585d

  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 9eab65174e7956c8486a054e2e003278bf36add2

  ambari-server/src/main/java/org/apache/ambari/server/agent/RegistrationResponse.java dae80bb49e64d137b527ee0daee47d105b367e91

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 80af5757ce052fa7973e72e48f63ecfb7bcafb02

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c6a33bef9f21d3cb97cea9675d53ce0abd3fb2d8

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
41a9996dd28e7be7e5ad20031d404c680641612c 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java e6f9b39afa318c0d8959d0c5e6a6e9b86ba1efcf

  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java
7cbd4b392bb76c9c9f97da96dada39376a3fe520 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestActionQueue.java 847db33f72c56cfabdabddb01e6b32f592548123

  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
9f0ccb0756b37a2075964ba9126c1b369aa76365 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java
a4d500cd999be322b2f1cefd9ba5dab53abc4913 
  ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java
c8fce4946496c2034b28df29dd3427d67178163d 

Diff: https://reviews.apache.org/r/24745/diff/


Testing
-------

These failing tests are not related to my changes.

Failed tests:   testReadViewArchives_exception(org.apache.ambari.server.view.ViewRegistryTest):
(..)

Tests in error:
testExecuteDDLUpdates(org.apache.ambari.server.upgrade.UpgradeCatalog170Test)


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message