ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Review Request 24623: Alerts: Update Oracle Alert DDL for CLOB
Date Wed, 13 Aug 2014 00:43:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24623/
-----------------------------------------------------------

Review request for Ambari and Nate Cole.


Bugs: AMBARI-6839
    https://issues.apache.org/jira/browse/AMBARI-6839


Repository: ambari


Description
-------

Noticed while doing the DAO work that the Oracle DDL scripts were using VARCHAR(4000) in some
places where MySQL and PostgreSQL were using TEXT. Adjusted the 2 fields that will contain
structured JSON data to be CLOB in these cases.

On upgrade, we're now using char[].class - The exact implementation of org.eclipse.persistence.platform.database.DatabasePlatform
will determine the actual field type to use (CLOB on Oracle, TEXT on MySQL, etc).


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java
3aa0e62 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java
6f9ab89 
  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java ab9d18b

  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6a8f35d 

Diff: https://reviews.apache.org/r/24623/diff/


Testing
-------

Manually ran the upgrade script and verified that the upgrade tests pass.


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message