ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitalyi Brodetskyi" <vbrodets...@hortonworks.com>
Subject Re: Review Request 24607: Postfixes for server-side implementation of Cancel requests
Date Tue, 12 Aug 2014 16:25:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24607/#review50334
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Aug. 12, 2014, 4:10 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24607/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 4:10 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6828
>     https://issues.apache.org/jira/browse/AMBARI-6828
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This jira focuses on issues that have not been solved at AMBARI-6760, namely:
> fix 10 existing unit tests that are failing
> Failed tests:   testIgnoreCustomActionReport(org.apache.ambari.server.agent.TestHeartbeatHandler)
> 
> Tests in error: 
>   testHeartbeatWithConfigs(org.apache.ambari.server.agent.TestHeartbeatHandler)
>   testHeartbeatCustomCommandWithConfigs(org.apache.ambari.server.agent.TestHeartbeatHandler)
>   testHeartbeatCustomStartStop(org.apache.ambari.server.agent.TestHeartbeatHandler)
>   testTaskInProgressHandling(org.apache.ambari.server.agent.TestHeartbeatHandler)
>   testCommandReportOnHeartbeatUpdatedState(org.apache.ambari.server.agent.TestHeartbeatHandler)
>   testUpgradeSpecificHandling(org.apache.ambari.server.agent.TestHeartbeatHandler)
>   testComponentUpgradeCompleteReport(org.apache.ambari.server.agent.TestHeartbeatHandler)
>   testComponentUpgradeInProgressReport(org.apache.ambari.server.agent.TestHeartbeatHandler)
>   testProcessStatusReports(org.apache.ambari.server.agent.TestHeartbeatHandler)
> Add unit tests for new functions
> Command reports for aborted tasks seem to be not showed at UI. Looks like they are cached
at a server level.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
dae9048 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
cab891f 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
a94f421 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
60ed592 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
349f09d 
> 
> Diff: https://reviews.apache.org/r/24607/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.885s]
> [INFO] Ambari Server ..................................... SUCCESS [16:48.829s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 16:57.364s
> [INFO] Finished at: Tue Aug 12 19:03:38 FET 2014
> [INFO] Final Memory: 23M/306M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message