ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 24428: Include configuration in exported blueprints
Date Wed, 06 Aug 2014 22:42:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24428/
-----------------------------------------------------------

(Updated Aug. 6, 2014, 10:42 p.m.)


Review request for Ambari, Mahadev Konar, Nate Cole, Sid Wagle, and Tom Beerbower.


Bugs: AMBARI-6762
    https://issues.apache.org/jira/browse/AMBARI-6762


Repository: ambari


Description
-------

Include both host group and cluster scoped configuration in an exported blueprint.
To export a blueprint, use the api:
AMBARI_HOST:8080/api/v1/clusters/:clustername?format=blueprint
The exported blueprint will contain the entire configuration for the associated cluster. The
only properties which are not included are those that are marked as "input required" in the
stack. All passwords are marked as required so they will not be exported. Also, any hostnames
in the configuration properties are replaced with a hostgroup token: %HOSTGROUP::group1%.
When a cluster is provisioned from the blueprint, the hostgroup tokens are resolved to host
names for the target cluster.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
db3dff8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
eff3854 
  ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationRequest.java
0130de4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java
d723512 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
f99955b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java
06d556d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostGroup.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java
4d2e60e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
d1aa4d5 

Diff: https://reviews.apache.org/r/24428/diff/


Testing
-------

Unit tests:
- New tests
- All tests pass

Results :

Tests run: 1883, Failures: 0, Errors: 0, Skipped: 14
...
Total run:544
Total errors:0
Total failures:0
OK

*Note: I did @Ignore a test for this commit.  The related functionality was tested in a functional
test.  I will add the test back tomorrow.

Functional Tests:
- Exported blueprints with configurations
- Created multiple clusters
-- from custom BP
-- from an exported BP with configuration 


Thanks,

John Speidel


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message