ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 24384: ATS is marked as slave component but appears on Assign Master Page on web-ui.
Date Wed, 06 Aug 2014 16:00:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24384/#review49739
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Aug. 6, 2014, 3:48 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24384/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 3:48 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-6755
>     https://issues.apache.org/jira/browse/AMBARI-6755
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> At some point, we marked ATS as slave component instead of master component in the API.
This seems incorrect. UI needs to have special cases to make this slave component appear as
master on web-ui. Rather we should mark ATS as master.
> 
> If we want the unavailability of ATS in secure mode should not affect yarn health status
then we should have another fix addressing it specifically but marking ATS as slave component
in the API does not seem right.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 7cf2e7b

>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/metainfo.xml
fcc0b47 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/metainfo.xml 7ebb32c

>   ambari-web/app/app.js 1964207 
>   ambari-web/app/controllers/wizard.js fcccf33 
>   ambari-web/app/controllers/wizard/step8_controller.js 83c2543 
>   ambari-web/app/models/stack_service_component.js 3d088c9 
>   ambari-web/app/views/main/service/service.js b19ac0d 
>   ambari-web/test/models/stack_service_component_test.js b92fcd1 
>   ambari-web/test/service_components.js 0f43be8 
> 
> Diff: https://reviews.apache.org/r/24384/diff/
> 
> 
> Testing
> -------
> 
> clean tests
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message