Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BCBB7112CE for ; Thu, 31 Jul 2014 23:07:00 +0000 (UTC) Received: (qmail 10186 invoked by uid 500); 31 Jul 2014 23:07:00 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 10163 invoked by uid 500); 31 Jul 2014 23:07:00 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 10138 invoked by uid 99); 31 Jul 2014 23:07:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jul 2014 23:07:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BDC741D9CEC; Thu, 31 Jul 2014 23:06:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7557146544161696269==" MIME-Version: 1.0 Subject: Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of global config_type From: "Vitalyi Brodetskyi" To: "John Speidel" , "Nate Cole" , "Vitalyi Brodetskyi" , "Mahadev Konar" Cc: "Andrew Onischuk" , "Ambari" Date: Thu, 31 Jul 2014 23:06:46 -0000 Message-ID: <20140731230646.18794.70999@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vitalyi Brodetskyi" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/24153/ X-Sender: "Vitalyi Brodetskyi" References: <20140731230338.18793.63856@reviews.apache.org> In-Reply-To: <20140731230338.18793.63856@reviews.apache.org> Reply-To: "Vitalyi Brodetskyi" X-ReviewRequest-Repository: ambari --===============7557146544161696269== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24153/#review49300 ----------------------------------------------------------- Ship it! Ship It! - Vitalyi Brodetskyi On July 31, 2014, 11:03 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24153/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 11:03 p.m.) > > > Review request for Ambari, John Speidel, Mahadev Konar, Nate Cole, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-6695 > https://issues.apache.org/jira/browse/AMBARI-6695 > > > Repository: ambari > > > Description > ------- > > How to handle support for blueprints + configs API where global configs are > set, since global config_type is being eliminated. > > * warn that global is deprecated > * map global to whatever-the-new-config-type automatically > > jspeidel this affects blueprints and the configs API > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7f53ded > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c65561e > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java b3a8019 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java b72beb6 > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38 > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java 392c316 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java d8f7fbc > > Diff: https://reviews.apache.org/r/24153/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > > --===============7557146544161696269==--