Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B359511524 for ; Wed, 23 Jul 2014 19:55:14 +0000 (UTC) Received: (qmail 33414 invoked by uid 500); 23 Jul 2014 19:55:14 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 33382 invoked by uid 500); 23 Jul 2014 19:55:14 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 33365 invoked by uid 99); 23 Jul 2014 19:55:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Jul 2014 19:55:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 759AE1DBA83; Wed, 23 Jul 2014 19:55:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3072375810947963426==" MIME-Version: 1.0 Subject: Re: Review Request 23836: Alerts: Add remaining CRUD operations for AlertDefinitions From: "Jonathan Hurley" To: "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Wed, 23 Jul 2014 19:55:01 -0000 Message-ID: <20140723195501.4204.71205@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jonathan Hurley" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/23836/ X-Sender: "Jonathan Hurley" References: <20140723024048.4204.85438@reviews.apache.org> In-Reply-To: <20140723024048.4204.85438@reviews.apache.org> Reply-To: "Jonathan Hurley" X-ReviewRequest-Repository: ambari --===============3072375810947963426== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23836/#review48548 ----------------------------------------------------------- Ship it! Ship It! - Jonathan Hurley On July 22, 2014, 10:40 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23836/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 10:40 p.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-6569 > https://issues.apache.org/jira/browse/AMBARI-6569 > > > Repository: ambari > > > Description > ------- > > Full CRUD support for AlertDefinitions. Also updated javadoc/misc comments from previous issues. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java ee3d29a > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c8ccf9a > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java c83615a > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java f8df108 > ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricAlert.java b565a3f > ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/state/alert/Source.java PRE-CREATION > ambari-server/src/main/resources/properties.json 4d5407c > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json c1918e5 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java de48756 > ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json 7988d8b > > Diff: https://reviews.apache.org/r/23836/diff/ > > > Testing > ------- > > Manual testing + new tests: > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 16:48.151s > [INFO] Finished at: Tue Jul 22 22:37:59 EDT 2014 > [INFO] Final Memory: 21M/123M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============3072375810947963426==--