Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6152728697248892536=="
MIME-Version: 1.0
Subject: Re: Review Request 23690: Ambari to warn of low disk space on any
 disk,
 including os and log partitions
From: "Dmytro Shkvyra" <dshkvyra@hortonworks.com>
To: "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>,
 "Dmytro Shkvyra" <dshkvyra@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>
Date: Mon, 21 Jul 2014 16:47:42 -0000
Message-ID: <20140721164742.4204.75322@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dmytro Shkvyra" <noreply@reviews.apache.org>
References: <20140721150427.4204.57560@reviews.apache.org>
In-Reply-To: <20140721150427.4204.57560@reviews.apache.org>
Reply-To: "Dmytro Shkvyra" <dshkvyra@hortonworks.com>

--===============6152728697248892536==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On July 21, 2014, 3:04 p.m., Nate Cole wrote:
> > Why isn't any of this returned with HostInfo and use that information straight out of Ambari?  Why add all this extra work on the agent to get the disk usage info when it should be part of HostInfo.

Because we also need have info about directories. This info is a part of AgentEnv, but agent send it to server once, when register. So, we have outdated information and we cant create alert for directories and mountpoints which were added after agent register. Also, creation of alerts on agent spillout load among hosts. In case, if we create alerts on server for 2k cluster we can have low performance.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23690/#review48230
-----------------------------------------------------------


On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23690/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6534
>     https://issues.apache.org/jira/browse/AMBARI-6534
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable).
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae 
>   ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 
> 
> Diff: https://reviews.apache.org/r/23690/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [7.032s]
> [INFO] Ambari Server ..................................... SUCCESS [18:15.609s]
> [INFO] Ambari Agent ...................................... SUCCESS [4.772s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:28.464s
> [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014
> [INFO] Final Memory: 22M/243M
> [INFO] ------------------------------------------------------------------------
>  
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


--===============6152728697248892536==--