Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F07B1121A for ; Mon, 21 Jul 2014 14:58:13 +0000 (UTC) Received: (qmail 20554 invoked by uid 500); 21 Jul 2014 14:58:13 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 20529 invoked by uid 500); 21 Jul 2014 14:58:13 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 20508 invoked by uid 99); 21 Jul 2014 14:58:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jul 2014 14:58:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7AA281DB9D8; Mon, 21 Jul 2014 14:58:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8641347193508820669==" MIME-Version: 1.0 Subject: Re: Review Request 23690: Ambari to warn of low disk space on any disk, including os and log partitions From: "Tom Beerbower" To: "Vitalyi Brodetskyi" , "Tom Beerbower" Cc: "Ambari" , "Dmitro Lisnichenko" Date: Mon, 21 Jul 2014 14:58:00 -0000 Message-ID: <20140721145800.4204.18035@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Tom Beerbower" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/23690/ X-Sender: "Tom Beerbower" References: <20140718180315.14170.64818@reviews.apache.org> In-Reply-To: <20140718180315.14170.64818@reviews.apache.org> Reply-To: "Tom Beerbower" X-ReviewRequest-Repository: ambari --===============8641347193508820669== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23690/#review48227 ----------------------------------------------------------- Ship it! Looks good. Could you have Nate Cole take a look also? ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java Is this required? If not can you remove it? - Tom Beerbower On July 18, 2014, 6:03 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23690/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 6:03 p.m.) > > > Review request for Ambari, Tom Beerbower and Vitalyi Brodetskyi. > > > Bugs: AMBARI-6534 > https://issues.apache.org/jira/browse/AMBARI-6534 > > > Repository: ambari > > > Description > ------- > > During runtime operations, log files and other external factors can contribute to filling disks that the Hadoop daemons depend on (eg /, /var/log, /tmp, any yarn-local-dirs). Ambari should watch for all these locations and warn when they fill up beyond a threshold like 80% (configurable). > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/Heartbeat.py 65a7a33 > ambari-agent/src/main/python/ambari_agent/HostInfo.py 69e3cae > ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 4703af4 > ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ba827ae > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java cdaf947 > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java 8b8b252 > ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java d609ecd > ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java 7c40ed1 > ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java be31893 > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 752a492 > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java da4a099 > ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java cc45ef0 > > Diff: https://reviews.apache.org/r/23690/diff/ > > > Testing > ------- > > [INFO] ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [7.032s] > [INFO] Ambari Server ..................................... SUCCESS [18:15.609s] > [INFO] Ambari Agent ...................................... SUCCESS [4.772s] > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 18:28.464s > [INFO] Finished at: Fri Jul 18 19:11:45 FET 2014 > [INFO] Final Memory: 22M/243M > [INFO] ------------------------------------------------------------------------ > > > > Thanks, > > Dmitro Lisnichenko > > --===============8641347193508820669==--