Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA60A11CC6 for ; Mon, 21 Jul 2014 12:33:29 +0000 (UTC) Received: (qmail 46263 invoked by uid 500); 21 Jul 2014 12:33:29 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 46238 invoked by uid 500); 21 Jul 2014 12:33:29 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 46220 invoked by uid 99); 21 Jul 2014 12:33:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jul 2014 12:33:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9F31E1DB9D8; Mon, 21 Jul 2014 12:33:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2899777214991800898==" MIME-Version: 1.0 Subject: Re: Review Request 23731: API call for hosts filtered by host_components/HostRoles/component_name returns 400 error From: "Dmytro Sen" To: "Nate Cole" , "Dmytro Sen" Cc: "Vitalyi Brodetskyi" , "Ambari" Date: Mon, 21 Jul 2014 12:33:16 -0000 Message-ID: <20140721123316.4203.22224@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/23731/ X-Sender: "Dmytro Sen" References: <20140721115857.4209.64046@reviews.apache.org> In-Reply-To: <20140721115857.4209.64046@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============2899777214991800898== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23731/#review48213 ----------------------------------------------------------- Ship it! Ship It! - Dmytro Sen On July 21, 2014, 11:58 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23731/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 11:58 a.m.) > > > Review request for Ambari, Dmytro Sen and Nate Cole. > > > Bugs: AMBARI-6546 > https://issues.apache.org/jira/browse/AMBARI-6546 > > > Repository: ambari > > > Description > ------- > > > When I try to get hosts filtered by host_components/HostRoles/component_name with != clause: > > http://host:8080/api/v1/clusters/my_cluster/hosts?host_components/HostRoles/component_name!=HBASE_MASTER > > API returns > { "status": 400, "message": "The properties [host_components/HostRoles/component_name] specified in the request or predicate are not supported for the resource type Host." } > > When I try to get hosts filtered by component with '=' clause: > http://host:8080/api/v1/clusters/my_cluster/hosts?host_components/HostRoles/component_name=HBASE_MASTER > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/query/ProcessingPredicateVisitor.java a9cd46c > ambari-server/src/main/java/org/apache/ambari/server/api/query/SubResourcePredicateVisitor.java 5ec2f10 > ambari-server/src/test/java/org/apache/ambari/server/api/query/ProcessingPredicateVisitorTest.java 393d5f5 > ambari-server/src/test/java/org/apache/ambari/server/api/query/SubResourcePredicateVisitorTest.java f6dbdd7 > > Diff: https://reviews.apache.org/r/23731/diff/ > > > Testing > ------- > > Results : > > Tests run: 1793, Failures: 0, Errors: 0, Skipped: 13 > > > Thanks, > > Vitalyi Brodetskyi > > --===============2899777214991800898==--