ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-6484) HBase RegionServer -Xmn must be configurable
Date Fri, 25 Jul 2014 14:12:39 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-6484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074423#comment-14074423
] 

Andrew Onischuk commented on AMBARI-6484:
-----------------------------------------

1.
{noformat}
+      "description": "Maximum value for minimum RegionServers Java heap size (Java option
-Xmn)",
+      "defaultValue": "512",
{noformat}
We should not hardcode description, and value on ui side, it's better remove these lines,
for new properties, in that case they are fetched from *-.xml files.

2.
{noformat}
+propertyUpdaters.put("hbase_regionserver_xmn_max", new MPropertyUpdater());
{noformat}
This line says we should append 'm' to the value when deploy via blueprint, we don't want
that to happen. We want '512', not '512m'

3.
{noformat}
+            "hbase_regionserver_xmn_max": "512m",
{noformat}
Also in all places like this we need to use 512 not '512m', that is what we need to pass to
calc_xmn_from_xms function -- a raw number.

1. Also how did you test it/build it?
2. Can you post mvn clean test output with the patch?

> HBase RegionServer -Xmn must be configurable
> --------------------------------------------
>
>                 Key: AMBARI-6484
>                 URL: https://issues.apache.org/jira/browse/AMBARI-6484
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 1.7.0
>            Reporter: Azwaw OUSADOU
>            Priority: Critical
>              Labels: features, patch
>             Fix For: 1.7.0
>
>         Attachments: AMBARI-6484.diff, XMN_CONFIGURABLE.diff
>
>
> -Xmn parameter for HBase RegionServer is calculated with hardcoded value.
> This patch allows you to configure values used to calculate this parameter (the maximum
value for -Xmn and the ratio between -Xmn and -Xmx).
> Without this fix HBase can be crash because of OutOfMemory when you do a YCSB test for
example.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message