ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin D Jetly (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-6481) Ambari showing pending upgrade instead of pending upgrade not finalized
Date Wed, 16 Jul 2014 00:11:05 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062910#comment-14062910
] 

Jaimin D Jetly commented on AMBARI-6481:
----------------------------------------

Just a minor observation.
Patch has a return statement for newly added computed property
{code}
return  (!upgradeStatus && healthStatus == 'green')? true: false;
{code}

This can be simplified to
{code}
return  !upgradeStatus && healthStatus == 'green';
{code}

Apart from the above observation,  +1 for the patch

> Ambari showing pending upgrade instead of pending upgrade not finalized
> -----------------------------------------------------------------------
>
>                 Key: AMBARI-6481
>                 URL: https://issues.apache.org/jira/browse/AMBARI-6481
>             Project: Ambari
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.6.0
>            Reporter: Xi Wang
>            Assignee: Xi Wang
>             Fix For: 1.7.0
>
>         Attachments: AMBARI-6481.patch
>
>
> Ambari is showing Upgrade pending instead of Upgrade is not finalized which is the correct
status of namenode.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message