ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin D Jetly (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AMBARI-6444) component to service mapping should not be hardcode
Date Wed, 09 Jul 2014 21:13:04 GMT

     [ https://issues.apache.org/jira/browse/AMBARI-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jaimin D Jetly updated AMBARI-6444:
-----------------------------------

    Description: 
App.QuickDataMapper.componentServiceMap() map and App.Service.DisplayNames map are hardcode
in the UI. These should not be used in the ambari-web code. 
App.StackServiceComponent model can be used to retrieve a serviceName for give componentName
for any service defined in a stack irrespective of it being installed or not.

Service Display name can also be derived from displayName computed property in App.Service
(model and it's extended models has information related to installed services like service
health and JMX retrived information) and App.StackService (model that has general information
related to all services in stack).

Also remove hard-coded references to the service names  in add_controller.js for add service
wizard. These references are used to conditionally skip Assign Slaves step. Everytime a new
service with slave component is introduced we needed to add a hard-coded reference to it.
For example experimental feature Flume service has slave component Flume handler but no reference
is being done over here [code|https://git-wip-us.apache.org/repos/asf/ambari/repo?p=ambari.git;a=blob;f=ambari-web/app/controllers/main/service/add_controller.js;h=89669ff96f56b421ac6757f7e53e1dd72edb64fe;hb=HEAD#l120]
and so while adding a Flume service, wizard skips "Assign Slave" step. These hard-coded logic
should be removed to fetch service with slave components dynamically.

  was:
App.QuickDataMapper.componentServiceMap() map and App.Service.DisplayNames map are hardcode
in the UI. These should not be used in the ambari-web code. 
App.StackServiceComponent model can be used to retrieve a serviceName for give componentName
for any service defined in a stack irrespective of it being installed or not.

Service Display name can also be derived from displayName computed property in App.Service
(model and it's extended models has information related to installed services like service
health and JMX retrived information) and App.StackService (model that has general information
related to all services in stack).

Also remove hard-coded references to the service names  in add_controller.js for add service
wizard. These references are used to conditionally skip Assign Slaves step. Everytime a new
service with slave component is introduced we needed to add a hard-coded reference to it.
For example experimental feature Flume service has slave component Flume handler but no reference
is being done over here [code|https://git-wip-us.apache.org/repos/asf/ambari/repo?p=ambari.git;a=blob;f=ambari-web/app/controllers/main/service/add_controller.js;h=89669ff96f56b421ac6757f7e53e1dd72edb64fe;hb=HEAD#l120]
and so while adding a Flume service, wizard skips "Assign Slave" step. These hard-coded logic
should be removed to fetch slave components dynamically.


> component to service mapping should not be hardcode
> ---------------------------------------------------
>
>                 Key: AMBARI-6444
>                 URL: https://issues.apache.org/jira/browse/AMBARI-6444
>             Project: Ambari
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.7.0
>            Reporter: Jaimin D Jetly
>            Assignee: Jaimin D Jetly
>             Fix For: 1.7.0
>
>
> App.QuickDataMapper.componentServiceMap() map and App.Service.DisplayNames map are hardcode
in the UI. These should not be used in the ambari-web code. 
> App.StackServiceComponent model can be used to retrieve a serviceName for give componentName
for any service defined in a stack irrespective of it being installed or not.
> Service Display name can also be derived from displayName computed property in App.Service
(model and it's extended models has information related to installed services like service
health and JMX retrived information) and App.StackService (model that has general information
related to all services in stack).
> Also remove hard-coded references to the service names  in add_controller.js for add
service wizard. These references are used to conditionally skip Assign Slaves step. Everytime
a new service with slave component is introduced we needed to add a hard-coded reference to
it. For example experimental feature Flume service has slave component Flume handler but no
reference is being done over here [code|https://git-wip-us.apache.org/repos/asf/ambari/repo?p=ambari.git;a=blob;f=ambari-web/app/controllers/main/service/add_controller.js;h=89669ff96f56b421ac6757f7e53e1dd72edb64fe;hb=HEAD#l120]
and so while adding a Flume service, wizard skips "Assign Slave" step. These hard-coded logic
should be removed to fetch service with slave components dynamically.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message