ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "subin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-6294) Python client is broken when pycurl isn't installed
Date Mon, 07 Jul 2014 14:54:33 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053721#comment-14053721
] 

subin commented on AMBARI-6294:
-------------------------------

We dont use pip to install ambari_client. the test cases are run via maven (command > mvn
test) 
To install ambari_client.
you need to build the source code , 
>mvn versions:set -DnewVersion=1.6.0-SNAPSHOT
>mvn -B clean install package rpm:rpm -DnewVersion=1.6.0-SNAPSHOT -DskipTests -Pcentos6
-Dpython.ver="python >= 2.6" -Preplaceurl
then >rpm -ivh <ambari_client.rpm>

If pycurl or other dependencies are not available we can add them to the rpm preinstall scripts.
We use CentOS/RHEL and yum update brings in most of  the python libraries on to our build
box.

But I am interested to know more about your pip support changes,



> Python client is broken when pycurl isn't installed
> ---------------------------------------------------
>
>                 Key: AMBARI-6294
>                 URL: https://issues.apache.org/jira/browse/AMBARI-6294
>             Project: Ambari
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.6.0
>            Reporter: Greg Hill
>            Assignee: subin
>
> If you don't have pycurl installed, trying to use the client causes a lot of problems.
 This line in http_client.py is at fault:
> try:
>   import pycurl
> except ImportError:
>   from mock.mock import MagicMock
>   pycurl = MagicMock() 
> There are a few problems here:
> 1. The tests should do the mocking, it shouldn't be done automatically when running outside
of tests.
> 2. mock.mock does not appear to be a valid module.  I can't install it via pip.  Did
you mean 'from mock import MagicMock'?
> 3. There is no dependency set on either pycurl or mock.mock, so using pip to install
ambari-client does not install it in a working state.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message