ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 24153: Configs API + Blueprints: Handle deprecation of global config_type
Date Thu, 31 Jul 2014 16:57:30 GMT


> On July 31, 2014, 4:40 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java,
lines 643-668
> > <https://reviews.apache.org/r/24153/diff/1/?file=646844#file646844line643>
> >
> >     Seems like adding configurations named 'global' shoudl still be allowed, even
if we don't use it.  We should ADD a -env set if a name was found, but not remove the key/value
pair from what was passed in.  That makes the behavior confusing:  "I passed in a name and
value that wasn't saved"

When we pass parameters which were not in global in past, they are still posted to global.
Not removed. Only the paramaters which are found in some -env are moved there.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24153/#review49241
-----------------------------------------------------------


On July 31, 2014, 4:09 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24153/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 4:09 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Nate Cole, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-6695
>     https://issues.apache.org/jira/browse/AMBARI-6695
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> How to handle support for blueprints + configs API where global configs are
> set, since global config_type is being eliminated.
> 
>   * warn that global is deprecated
>   * map global to whatever-the-new-config-type automatically
> 
> jspeidel this affects blueprints and the configs API
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
7f53ded 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 906cba4

>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java
b3a8019 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
b72beb6 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 81c3c38

>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
5f67a30 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
d8f7fbc 
> 
> Diff: https://reviews.apache.org/r/24153/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message