ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myroslav Papirkovskyy" <mpapyrkovs...@hortonworks.com>
Subject Re: Review Request 23984: Fix upgrade to respect -env
Date Tue, 29 Jul 2014 12:14:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23984/#review48979
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On July 28, 2014, 6:32 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23984/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 6:32 p.m.)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-6635
>     https://issues.apache.org/jira/browse/AMBARI-6635
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> What I think about. Is is automatically mapping properties from global to
> different envs. This is less error-prone and easier to maintain rather than
> hardcoding the mapping.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java 7f5b3ce

>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 9575385

>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
4d21d79 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java
e409580 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java
c4b0273 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java
39292d8 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
31a5883 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java
3d54874 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java
738e9d8 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java
79007d5 
> 
> Diff: https://reviews.apache.org/r/23984/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message