ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 23857: Provide API to support which RM is Active/Passive.
Date Wed, 23 Jul 2014 16:09:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23857/#review48519
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpProxyPropertyProvider.java
<https://reviews.apache.org/r/23857/#comment85181>

    In this case it will return result, whatever it may be.  Is that what you intended?  I
wonder if it should return null, meaning that the requested property value can't be found.
 Then the caller would have to check for null return.


- Tom Beerbower


On July 23, 2014, 3:59 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23857/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 3:59 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Tom Beerbower.
> 
> 
> Bugs: AMBARI-6581
>     https://issues.apache.org/jira/browse/AMBARI-6581
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Provide API to support which RM is Active/Passive.
> 
> We need to provide API support for the user to know which RM is active. All the RM's
should have a property which should be either active or passive.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
89d53ae 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpProxyPropertyProvider.java
d39518c 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
08a72bb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HttpPropertyProviderTest.java
ba08dfc 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
6e8cb9f 
> 
> Diff: https://reviews.apache.org/r/23857/diff/
> 
> 
> Testing
> -------
> 
> test clean
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message