ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 22090: Usability: Add checks for THP to the Ambari pre-req check for Linux
Date Mon, 07 Jul 2014 16:53:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22090/#review47396
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On July 7, 2014, 4:46 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22090/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 4:46 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5973
>     https://issues.apache.org/jira/browse/AMBARI-5973
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We need to add checks for Transparent Huge Page. With it enabled, we have
> pretty horrible performance, and it's enabled by default on RHEL.
> 
> Reference: <https://access.redhat.com/site/documentation/en-
> US/Red_Hat_Enterprise_Linux/6/html/Performance_Tuning_Guide/s-memory-
> transhuge.html>
> 
> What we need to do pseudo code:
> 
> if (`cat /sys/kernel/mm/redhat_transparent_hugepage/enabled` != 'never'); then  
> echo never > /sys/kernel/mm/redhat_transparent_hugepage/enabled  
> end
> 
> We need to add a check, and then add the 'echo never' to the python script.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 940305a 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 75704ef 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/AgentEnv.java eed901c 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java aba2f62

> 
> Diff: https://reviews.apache.org/r/22090/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message