ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Review Request 23275: Need a cleanup of global.xml properties no longer used by agent
Date Fri, 04 Jul 2014 14:38:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23275/
-----------------------------------------------------------

Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-6389
    https://issues.apache.org/jira/browse/AMBARI-6389


Repository: ambari


Description
-------

A lot of the global.xml properties are outdated.  
**Example**: dfs_namenode_name_dir

<https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/
stacks/HDP/2.0.6/services/HDFS/configuration/global.xml>

**Note**:  
Wee needed to have this duplication since Puppet 2.7 did not allow "." in
variable names.

The agent code has been long since refactored to use the values coming for the
actual configuration.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml
e7a3001 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml
701036e 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml
12e01f8 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml
657317b 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml
ac60027 
  ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HDFS/configuration/global.xml
49d66bb 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml
7540276 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml
aef5a20 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml
3b4db58 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py
dc3fbb6 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml
3c7b035 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py
59451aa 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml
ac60027 
  ambari-web/app/data/HDP2/global_properties.js f4868ca 
  ambari-web/app/data/global_properties.js 4812eb2 

Diff: https://reviews.apache.org/r/23275/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message