ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 23234: Add more info about the Heartbeat message from Ambari Agent to Server in its logs
Date Wed, 02 Jul 2014 19:49:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23234/
-----------------------------------------------------------

(Updated July 2, 2014, 3:49 p.m.)


Review request for Ambari, Nate Cole and Sid Wagle.


Bugs: AMBARI-6356
    https://issues.apache.org/jira/browse/AMBARI-6356


Repository: ambari


Description
-------

The major request here was for some better logging of IP addresses between the server and
the agents. There were some areas where, on an Exception, the python code would reference
an undefined local variable, causing the exception message to be lost. Those were all fixed
up.


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/Controller.py 9839313 
  ambari-agent/src/main/python/ambari_agent/Heartbeat.py 6c7543e 
  ambari-agent/src/main/python/ambari_agent/LiveStatus.py 49cea62 
  ambari-agent/src/main/python/ambari_agent/NetUtil.py ece7b8f 
  ambari-agent/src/main/python/ambari_agent/main.py 78dde9e 
  ambari-agent/src/test/python/ambari_agent/TestController.py 30e03c4 
  ambari-agent/src/test/python/ambari_agent/TestMain.py afe9b59 

Diff: https://reviews.apache.org/r/23234/diff/


Testing
-------

[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.401s
[INFO] Finished at: Wed Jul 02 12:32:32 EDT 2014
[INFO] Final Memory: 7M/81M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message