ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 23234: Add more info about the Heartbeat message from Ambari Agent to Server in its logs
Date Wed, 02 Jul 2014 18:48:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23234/#review47219
-----------------------------------------------------------


Yay whitespace!


ambari-agent/src/main/python/ambari_agent/Controller.py
<https://reviews.apache.org/r/23234/#comment82856>

    This may lead to some confusion on 0.0.0.0 when trying to connect on a bad name.  May
want to consider moving the logger.info("Registering...") into each appropriate block (one
for failure and one for success).  Or we should fail straight up if the host could not be
resolved.
    
    Also, the doc says "If the host name is an IPv4 address itself it is returned unchanged"
- not sure if an actual network resolution will occur then.



ambari-agent/src/main/python/ambari_agent/Heartbeat.py
<https://reviews.apache.org/r/23234/#comment82857>

    (nit) I like this pattern, but if we do this for debug, why not do it for info messages
too?  Also use with debug isn't consistent either.  I don't think this patch should have to
address it.



ambari-agent/src/main/python/ambari_agent/NetUtil.py
<https://reviews.apache.org/r/23234/#comment82858>

    Should be debug?



ambari-agent/src/main/python/ambari_agent/NetUtil.py
<https://reviews.apache.org/r/23234/#comment82859>

    Debug?



ambari-agent/src/main/python/ambari_agent/main.py
<https://reviews.apache.org/r/23234/#comment82860>

    See earlier comment.  Should be the same.


- Nate Cole


On July 2, 2014, 12:47 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23234/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 12:47 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sid Wagle.
> 
> 
> Bugs: AMBARI-6356
>     https://issues.apache.org/jira/browse/AMBARI-6356
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The major request here was for some better logging of IP addresses between the server
and the agents. There were some areas where, on an Exception, the python code would reference
an undefined local variable, causing the exception message to be lost. Those were all fixed
up.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py 9839313 
>   ambari-agent/src/main/python/ambari_agent/Heartbeat.py 6c7543e 
>   ambari-agent/src/main/python/ambari_agent/LiveStatus.py 49cea62 
>   ambari-agent/src/main/python/ambari_agent/NetUtil.py ece7b8f 
>   ambari-agent/src/main/python/ambari_agent/main.py 78dde9e 
>   ambari-agent/src/test/python/ambari_agent/TestController.py 30e03c4 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py afe9b59 
> 
> Diff: https://reviews.apache.org/r/23234/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 157
licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6.401s
> [INFO] Finished at: Wed Jul 02 12:32:32 EDT 2014
> [INFO] Final Memory: 7M/81M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message