Return-Path: 
 <dev-return-32030-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 1C2841015C
	for <apmail-ambari-dev-archive@www.apache.org>;
 Wed, 25 Jun 2014 13:58:44 +0000 (UTC)
Received: (qmail 94713 invoked by uid 500); 25 Jun 2014 13:58:44 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 94693 invoked by uid 500); 25 Jun 2014 13:58:44 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 94676 invoked by uid 99); 25 Jun 2014 13:58:43 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jun 2014 13:58:43 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 1F5B71DB1E2;
	Wed, 25 Jun 2014 13:58:33 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============2197202050412776256=="
MIME-Version: 1.0
Subject: Re: Review Request 22940: Return field host_components fully when
 hosts
 filtered (Hosts table's filtering by Host Components won't work without this)
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Sid Wagle" <swagle@hortonworks.com>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Dmytro Sen" <dsen@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Wed, 25 Jun 2014 13:58:33 -0000
Message-ID: <20140625135833.22603.82102@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/22940/
X-Sender: "Tom Beerbower" <noreply@reviews.apache.org>
References: <20140625134932.22596.94568@reviews.apache.org>
In-Reply-To: <20140625134932.22596.94568@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============2197202050412776256==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22940/#review46620
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On June 25, 2014, 1:49 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22940/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 1:49 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Tom Beerbower.
> 
> 
> Bugs: AMBARI-6262
>     https://issues.apache.org/jira/browse/AMBARI-6262
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Follow request:
> {noformat}
> /api/v1/clusters/<cluster-name>/hosts?host_components/HostRoles/component_name.in(<component-names>)&fields=host_components
> {noformat}
> should return host_components field with all host-components on the host, not just ones that in filter.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 104f994 
>   ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java ad453d9 
> 
> Diff: https://reviews.apache.org/r/22940/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [1.822s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.314s]
> [INFO] Ambari Web ........................................ SUCCESS [23.185s]
> [INFO] Ambari Views ...................................... SUCCESS [1.573s]
> [INFO] Ambari Server ..................................... SUCCESS [14:21.214s]
> [INFO] Ambari Agent ...................................... SUCCESS [3.588s]
> [INFO] Ambari Client ..................................... SUCCESS [0.032s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.267s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [8.225s]
> [INFO] Ambari Shell ...................................... SUCCESS [4.582s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


--===============2197202050412776256==--