Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C754510794 for ; Mon, 23 Jun 2014 15:03:24 +0000 (UTC) Received: (qmail 46309 invoked by uid 500); 23 Jun 2014 15:03:23 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 46279 invoked by uid 500); 23 Jun 2014 15:03:23 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 46266 invoked by uid 99); 23 Jun 2014 15:03:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jun 2014 15:03:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0EEDC1DB187; Mon, 23 Jun 2014 15:03:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0702680835405277283==" MIME-Version: 1.0 Subject: Review Request 22870: Remove legacy metainfo.xml V1 support (ServiceMetainfoXml.java) From: "Dmitro Lisnichenko" To: "Dmytro Sen" Cc: "Dmitro Lisnichenko" , "Ambari" Date: Mon, 23 Jun 2014 15:03:13 -0000 Message-ID: <20140623150313.22595.42941@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmitro Lisnichenko" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/22870/ X-Sender: "Dmitro Lisnichenko" Reply-To: "Dmitro Lisnichenko" X-ReviewRequest-Repository: ambari --===============0702680835405277283== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22870/ ----------------------------------------------------------- Review request for Ambari and Dmytro Sen. Bugs: AMBARI-6239 https://issues.apache.org/jira/browse/AMBARI-6239 Repository: ambari Description ------- No need to support metainfo.xml schema_version 1 . Isn't used after PUPPET>PYTHON transition A lot of ambari-server unit tests use metainfo.xml v1 configs. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 3675b6a ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 5700ccf ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 7faa046 ambari-server/src/main/java/org/apache/ambari/server/state/stack/ServiceMetainfoXml.java 9104d95 ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java d806869 ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java c25575f ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 4b7a0a4 ambari-server/src/test/resources/stacks/HDP/0.1/services/HDFS/metainfo.xml 3c42b9b ambari-server/src/test/resources/stacks/HDP/0.1/services/MAPREDUCE/metainfo.xml 2114480 ambari-server/src/test/resources/stacks/HDP/0.1/services/PIG/metainfo.xml c89afa7 ambari-server/src/test/resources/stacks/HDP/0.2/services/HBASE/metainfo.xml d584d7f ambari-server/src/test/resources/stacks/HDP/0.2/services/HDFS/metainfo.xml 622f0fd ambari-server/src/test/resources/stacks/HDP/0.2/services/HIVE/metainfo.xml 22a86e3 ambari-server/src/test/resources/stacks/HDP/0.2/services/MAPREDUCE/metainfo.xml 2114480 ambari-server/src/test/resources/stacks/HDP/0.2/services/ZOOKEEPER/metainfo.xml 7b73682 ambari-server/src/test/resources/stacks/HDP/1.2.0/metainfo.xml PRE-CREATION ambari-server/src/test/resources/stacks/HDP/1.2.0/services/GANGLIA/metainfo.xml 0b21f0f ambari-server/src/test/resources/stacks/HDP/1.2.0/services/HBASE/metainfo.xml c91d9f0 ambari-server/src/test/resources/stacks/HDP/1.2.0/services/HCATALOG/metainfo.xml 1951a5d ambari-server/src/test/resources/stacks/HDP/1.2.0/services/HDFS/metainfo.xml 1b185e1 ambari-server/src/test/resources/stacks/HDP/1.2.0/services/HIVE/metainfo.xml 6a52064 ambari-server/src/test/resources/stacks/HDP/1.2.0/services/MAPREDUCE/metainfo.xml 79d219b ambari-server/src/test/resources/stacks/HDP/1.2.0/services/NAGIOS/metainfo.xml bd7de07 ambari-server/src/test/resources/stacks/HDP/1.2.0/services/OOZIE/metainfo.xml 83ccb06 ambari-server/src/test/resources/stacks/HDP/1.2.0/services/PIG/metainfo.xml 4982fd2 ambari-server/src/test/resources/stacks/HDP/1.2.0/services/SQOOP/metainfo.xml ae0e68b ambari-server/src/test/resources/stacks/HDP/1.2.0/services/WEBHCAT/metainfo.xml e65992f ambari-server/src/test/resources/stacks/HDP/1.2.0/services/ZOOKEEPER/metainfo.xml fc0c3b5 ambari-server/src/test/resources/stacks/HDP/1.3.0/services/GANGLIA/metainfo.xml 0b21f0f ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HBASE/metainfo.xml 1bb3d14 ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HCATALOG/metainfo.xml dd5ff08 ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HDFS/metainfo.xml c29bb61 ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HIVE/metainfo.xml 520ccec ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HUE/metainfo.xml c6e384f ambari-server/src/test/resources/stacks/HDP/1.3.0/services/MAPREDUCE/metainfo.xml b4a95a0 ambari-server/src/test/resources/stacks/HDP/1.3.0/services/NAGIOS/metainfo.xml bd7de07 ambari-server/src/test/resources/stacks/HDP/1.3.0/services/OOZIE/metainfo.xml 46460b4 ambari-server/src/test/resources/stacks/HDP/1.3.0/services/PIG/metainfo.xml 6806c54 ambari-server/src/test/resources/stacks/HDP/1.3.0/services/SQOOP/metainfo.xml 1924c54 ambari-server/src/test/resources/stacks/HDP/1.3.0/services/WEBHCAT/metainfo.xml 15c8daa ambari-server/src/test/resources/stacks/HDP/1.3.0/services/ZOOKEEPER/metainfo.xml 3dc129b ambari-server/src/test/resources/stacks/HDP/1.3.1/services/GANGLIA/metainfo.xml 0b21f0f ambari-server/src/test/resources/stacks/HDP/1.3.1/services/HBASE/metainfo.xml 553fa2b ambari-server/src/test/resources/stacks/HDP/1.3.1/services/HCATALOG/metainfo.xml 1951a5d ambari-server/src/test/resources/stacks/HDP/1.3.1/services/HCFS/metainfo.xml 212e53e ambari-server/src/test/resources/stacks/HDP/1.3.1/services/HDFS/metainfo.xml 1b185e1 ambari-server/src/test/resources/stacks/HDP/1.3.1/services/HIVE/metainfo.xml 6a52064 ambari-server/src/test/resources/stacks/HDP/1.3.1/services/MAPREDUCE/metainfo.xml 79d219b ambari-server/src/test/resources/stacks/HDP/1.3.1/services/NAGIOS/metainfo.xml bd7de07 ambari-server/src/test/resources/stacks/HDP/1.3.1/services/NONAME/metainfo.xml 47e7291 ambari-server/src/test/resources/stacks/HDP/1.3.1/services/OOZIE/metainfo.xml 83ccb06 ambari-server/src/test/resources/stacks/HDP/1.3.1/services/PIG/metainfo.xml 4982fd2 ambari-server/src/test/resources/stacks/HDP/1.3.1/services/SQOOP/metainfo.xml ae0e68b ambari-server/src/test/resources/stacks/HDP/1.3.1/services/WEBHCAT/metainfo.xml e65992f ambari-server/src/test/resources/stacks/HDP/1.3.1/services/ZOOKEEPER/metainfo.xml 0e21f4f ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HUE/metainfo.xml 0a6b59e ambari-server/src/test/resources/stacks/HDP/2.0.1/services/GANGLIA/metainfo.xml 395bb4f ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HBASE/metainfo.xml 645f7ce ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HCATALOG/metainfo.xml 45f3342 ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HDFS/metainfo.xml 1fbfbe6 ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/metainfo.xml c87b494 ambari-server/src/test/resources/stacks/HDP/2.0.1/services/MAPREDUCE2/metainfo.xml 7c4d1f4 ambari-server/src/test/resources/stacks/HDP/2.0.1/services/NAGIOS/metainfo.xml bd7de07 ambari-server/src/test/resources/stacks/HDP/2.0.1/services/OOZIE/metainfo.xml a65b547 ambari-server/src/test/resources/stacks/HDP/2.0.1/services/PIG/metainfo.xml 731d7b0 ambari-server/src/test/resources/stacks/HDP/2.0.1/services/TEZ/metainfo.xml 30aa43e ambari-server/src/test/resources/stacks/HDP/2.0.1/services/WEBHCAT/metainfo.xml e65992f ambari-server/src/test/resources/stacks/HDP/2.0.1/services/YARN/metainfo.xml 743c40d ambari-server/src/test/resources/stacks/HDP/2.0.1/services/ZOOKEEPER/metainfo.xml e72fd2a ambari-server/src/test/resources/stacks/HDP/2.0.5/services/GANGLIA/metainfo.xml 9f7444b ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HBASE/metainfo.xml f627b48 ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HCATALOG/metainfo.xml a2f075b ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/metainfo.xml d1fc36b ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/metainfo.xml 7c5ad04 ambari-server/src/test/resources/stacks/HDP/2.0.5/services/MAPREDUCE2/metainfo.xml 2868140 ambari-server/src/test/resources/stacks/HDP/2.0.5/services/OOZIE/metainfo.xml 05e093d ambari-server/src/test/resources/stacks/HDP/2.0.5/services/PIG/metainfo.xml 84cf04e ambari-server/src/test/resources/stacks/HDP/2.0.5/services/SQOOP/metainfo.xml 566ba36 ambari-server/src/test/resources/stacks/HDP/2.0.5/services/WEBHCAT/metainfo.xml 1ee2f7d ambari-server/src/test/resources/stacks/HDP/2.0.5/services/YARN/metainfo.xml b196c83 ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml 41d907e ambari-server/src/test/resources/stacks/HDP/2.0.6/services/SQOOP/metainfo.xml 50ff0ed ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/metainfo.xml 6f02f79 ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/metainfo.xml 15b95fa Diff: https://reviews.apache.org/r/22870/diff/ Testing ------- [INFO] Reactor Summary: [INFO] [INFO] Ambari Views ...................................... SUCCESS [5.019s] [INFO] Ambari Server ..................................... SUCCESS [13:12.190s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 13:17.926s [INFO] Finished at: Mon Jun 23 17:16:38 FET 2014 [INFO] Final Memory: 24M/199M [INFO] ------------------------------------------------------------------------ Thanks, Dmitro Lisnichenko --===============0702680835405277283==--