Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D9823CBD7 for ; Thu, 5 Jun 2014 16:27:54 +0000 (UTC) Received: (qmail 51180 invoked by uid 500); 5 Jun 2014 16:27:54 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 51151 invoked by uid 500); 5 Jun 2014 16:27:54 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 51139 invoked by uid 99); 5 Jun 2014 16:27:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jun 2014 16:27:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E0ACA1D9B08; Thu, 5 Jun 2014 16:27:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5802449528356598751==" MIME-Version: 1.0 Subject: Re: Review Request 22264: structured_out should be a JSON object, not stringified JSON From: "Vitalyi Brodetskyi" To: "Vitalyi Brodetskyi" Cc: "Dmitro Lisnichenko" , "Ambari" Date: Thu, 05 Jun 2014 16:27:45 -0000 Message-ID: <20140605162745.12449.34702@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vitalyi Brodetskyi" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/22264/ X-Sender: "Vitalyi Brodetskyi" References: <20140605140324.12450.57269@reviews.apache.org> In-Reply-To: <20140605140324.12450.57269@reviews.apache.org> Reply-To: "Vitalyi Brodetskyi" X-ReviewRequest-Repository: ambari --===============5802449528356598751== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22264/#review44820 ----------------------------------------------------------- Ship it! Ship It! - Vitalyi Brodetskyi On June 5, 2014, 2:03 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22264/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 2:03 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-6030 > https://issues.apache.org/jira/browse/AMBARI-6030 > > > Repository: ambari > > > Description > ------- > > Structured_out attribute from Custom Action API is now a stringified JSON. This should be changed to pure JSON. > Stringified JSON is really hard to read, does not format well, and also there's no reason for the FE to do JSON parse twice (once for the API response and then another to parse structured_out). > We should fix this for 1.6.1 before this becomes permanent. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java f0d2c06 > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 7efd0f3 > > Diff: https://reviews.apache.org/r/22264/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > > --===============5802449528356598751==--