Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A2935C1F4 for ; Thu, 5 Jun 2014 12:18:33 +0000 (UTC) Received: (qmail 86053 invoked by uid 500); 5 Jun 2014 12:18:33 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 86023 invoked by uid 500); 5 Jun 2014 12:18:33 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 86009 invoked by uid 99); 5 Jun 2014 12:18:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jun 2014 12:18:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7BF391D9AA3; Thu, 5 Jun 2014 12:18:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0102419225956940322==" MIME-Version: 1.0 Subject: Re: Review Request 22208: Incorrect behaviour when trying to execute upgradestack to nonexistent HDP version From: "Dmytro Shkvyra" To: "Dmitro Lisnichenko" Cc: "Andrew Onischuk" , "Dmytro Shkvyra" , "Nate Cole" , "Ambari" Date: Thu, 05 Jun 2014 12:18:24 -0000 Message-ID: <20140605121824.12450.73509@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmytro Shkvyra" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/22208/ X-Sender: "Dmytro Shkvyra" References: <20140604161755.12452.7168@reviews.apache.org> In-Reply-To: <20140604161755.12452.7168@reviews.apache.org> Reply-To: "Dmytro Shkvyra" X-ReviewRequest-Repository: ambari --===============0102419225956940322== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On June 4, 2014, 4:17 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java, lines 138-149 > > > > > > Can just propagate the IOException. A generic Exception is thrown when this function is false anyway. At very least write a log statement showing what happened to help the user make it right. I agree with you. I'll throw Exception with more informative message - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22208/#review44719 ----------------------------------------------------------- On June 4, 2014, 4:07 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22208/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 4:07 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-6008 > https://issues.apache.org/jira/browse/AMBARI-6008 > > > Repository: ambari > > > Description > ------- > > > [root@dev01 ~]# ambari-server upgradestack HDP-2.3.4 > Using python /usr/bin/python2.6 > Upgrading stack of ambari-server > WARNING: could not change directory to "/root" > > Ambari Server 'upgradestack' completed successfully. > > > Ambari should consider the validity of the data if was specified the invalid > HDP version and give the correct message about this. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069 > ambari-server/src/main/python/ambari-server.py 6ad94d5 > ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION > ambari-server/src/test/python/TestAmbariServer.py c2d868d > > Diff: https://reviews.apache.org/r/22208/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > > --===============0102419225956940322==--