Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2F6F01150C for ; Tue, 3 Jun 2014 20:27:43 +0000 (UTC) Received: (qmail 27680 invoked by uid 500); 3 Jun 2014 20:27:43 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 27647 invoked by uid 500); 3 Jun 2014 20:27:43 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 27634 invoked by uid 99); 3 Jun 2014 20:27:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2014 20:27:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4EBBD1D9AB6; Tue, 3 Jun 2014 20:27:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9080871772291491760==" MIME-Version: 1.0 Subject: Re: Review Request 22216: HDFS alert hangs for a long time after enabling Maintenance mode From: "Nate Cole" To: "Nate Cole" , "Sid Wagle" Cc: "Jonathan Hurley" , "Ambari" Date: Tue, 03 Jun 2014 20:27:34 -0000 Message-ID: <20140603202734.12449.2864@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/22216/ X-Sender: "Nate Cole" References: <20140603201715.12452.31617@reviews.apache.org> In-Reply-To: <20140603201715.12452.31617@reviews.apache.org> Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============9080871772291491760== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22216/#review44662 ----------------------------------------------------------- Ship it! Ship It! - Nate Cole On June 3, 2014, 4:17 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22216/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 4:17 p.m.) > > > Review request for Ambari, Nate Cole and Sid Wagle. > > > Bugs: AMBARI-6014 > https://issues.apache.org/jira/browse/AMBARI-6014 > > > Repository: ambari > > > Description > ------- > > NAGIOS_* macros are required by our scripts in order to allow maintenance model exit code alterations. Also, there was an error in the scripts which would always cause the if-statement to execute, regardless of ignore.dat contents. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh 600cc5c > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/nagios.cfg.j2 c778b2e > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh d198014 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/nagios.cfg.j2 c778b2e > > Diff: https://reviews.apache.org/r/22216/diff/ > > > Testing > ------- > > Install of Nagios with verification that the script entered the correct if/else structure and matched on the triple-grep. > > Also: > > ---------------------------------------------------------------------- > Total run:563 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Jonathan Hurley > > --===============9080871772291491760==--