Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E5ED61181D for ; Mon, 2 Jun 2014 16:53:24 +0000 (UTC) Received: (qmail 97761 invoked by uid 500); 2 Jun 2014 16:53:24 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 97735 invoked by uid 500); 2 Jun 2014 16:53:24 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 97723 invoked by uid 99); 2 Jun 2014 16:53:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jun 2014 16:53:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 27D7F1D9A0D; Mon, 2 Jun 2014 16:53:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8608313623721327268==" MIME-Version: 1.0 Subject: Review Request 22146: Unit Testing Improvments : Examine TestPassFileGeneration.testPassFileGen From: "Dmytro Sen" To: "Tom Beerbower" Cc: "Dmytro Sen" , "Ambari" Date: Mon, 02 Jun 2014 16:53:16 -0000 Message-ID: <20140602165316.12450.14806@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/22146/ X-Sender: "Dmytro Sen" Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============8608313623721327268== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22146/ ----------------------------------------------------------- Review request for Ambari and Tom Beerbower. Bugs: AMBARI-5993 https://issues.apache.org/jira/browse/AMBARI-5993 Repository: ambari Description ------- In an effort to reduce the amount of time it takes to run the unit tests we should examine slowest of them and see if we can make improvements through the use of mocks or common setup or something else. This is one of the slowest ... 12.004torg.apache.ambari.server.security.TestPassFileGeneration.testPassFileGen Diffs ----- ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java 45ced24 ambari-server/src/test/java/org/apache/ambari/server/security/TestPassFileGeneration.java dc35e5d Diff: https://reviews.apache.org/r/22146/diff/ Testing ------- [INFO] Ambari Main ....................................... SUCCESS [1.844s] [INFO] Apache Ambari Project POM ......................... SUCCESS [0.268s] [INFO] Ambari Web ........................................ SUCCESS [9.978s] [INFO] Ambari Views ...................................... SUCCESS [2.308s] [INFO] Ambari Server ..................................... SUCCESS [13:22.239s] [INFO] Ambari Agent ...................................... SUCCESS [5.066s] [INFO] Ambari Client ..................................... SUCCESS [0.041s] [INFO] Ambari Python Client .............................. SUCCESS [0.486s] [INFO] Ambari Groovy Client .............................. SUCCESS [3.724s] [INFO] Ambari Shell ...................................... SUCCESS [4.282s] Thanks, Dmytro Sen --===============8608313623721327268==--