Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B114E11682 for ; Mon, 2 Jun 2014 16:21:39 +0000 (UTC) Received: (qmail 16521 invoked by uid 500); 2 Jun 2014 16:21:39 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 16491 invoked by uid 500); 2 Jun 2014 16:21:39 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 16479 invoked by uid 99); 2 Jun 2014 16:21:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jun 2014 16:21:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C251B1D9A0E; Mon, 2 Jun 2014 16:21:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6430452606444790274==" MIME-Version: 1.0 Subject: Re: Review Request 22140: Nagios templates for 1.x and 2.x stacks contain irrelevant services From: "Dmytro Sen" To: "Dmytro Sen" Cc: "Dmitro Lisnichenko" , "Ambari" Date: Mon, 02 Jun 2014 16:21:30 -0000 Message-ID: <20140602162130.12450.52408@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/22140/ X-Sender: "Dmytro Sen" References: <20140602160358.12452.16322@reviews.apache.org> In-Reply-To: <20140602160358.12452.16322@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============6430452606444790274== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22140/#review44502 ----------------------------------------------------------- Ship it! Ship It! - Dmytro Sen On June 2, 2014, 4:03 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22140/ > ----------------------------------------------------------- > > (Updated June 2, 2014, 4:03 p.m.) > > > Review request for Ambari and Dmytro Sen. > > > Bugs: AMBARI-5990 > https://issues.apache.org/jira/browse/AMBARI-5990 > > > Repository: ambari > > > Description > ------- > > Currently, Nagios templates for 1.x and 2.x stacks are (almost ?) the same. That means that we have Resource Manager/Node Manager alert definitions at 1.3.2 stack and Job Tracker/Task Tracker alerts definitions at 2.0.6 stack. > Exact files are > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/params.py 5df2767 > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 74e6e48 > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 a42d795 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py 92886ab > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 007cc78 > > Diff: https://reviews.apache.org/r/22140/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 207 tests in 1.763s > > OK > ---------------------------------------------------------------------- > Total run:560 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmitro Lisnichenko > > --===============6430452606444790274==--