ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Review Request 22972: Repoinfo.xml should use family tag rather than type tag
Date Wed, 25 Jun 2014 17:12:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22972/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-6270
    https://issues.apache.org/jira/browse/AMBARI-6270


Repository: ambari


Description
-------

That is a bit confusing we should change that, since we changed the way it
works

    
    
    
    <os type="redhat6">
    

should be

    
    
    
    <os family="redhat6">
    


Diffs
-----

  ambari-common/src/main/python/ambari_commons/os_check.py f652d06 
  ambari-common/src/main/python/ambari_commons/resources/os_family.json PRE-CREATION 
  ambari-server/conf/unix/ambari.properties b5816af 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 9bbebf5

  ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 7795c99 
  ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BootStrapImpl.java 1f68f1f

  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 226cf86

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 40ef3ea 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java bd98a9f

  ambari-server/src/main/python/ambari-server.py 7987b95 
  ambari-server/src/main/python/bootstrap.py 4d0c976 
  ambari-server/src/main/python/os_check_type.py 7fefed3 
  ambari-server/src/main/resources/os_family.json be030e3 
  ambari-server/src/main/resources/stacks/HDP/1.2.0/repos/repoinfo.xml 6758389 
  ambari-server/src/main/resources/stacks/HDP/1.2.1/repos/repoinfo.xml b7932f1 
  ambari-server/src/main/resources/stacks/HDP/1.3.0/repos/repoinfo.xml a44462a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2.GlusterFS/repos/repoinfo.xml eace5c0 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/repos/repoinfo.xml 0486765 
  ambari-server/src/main/resources/stacks/HDP/1.3.3/repos/repoinfo.xml e3f7494 
  ambari-server/src/main/resources/stacks/HDP/1.3/repos/repoinfo.xml 904fce1 
  ambari-server/src/main/resources/stacks/HDP/2.0.5/repos/repoinfo.xml dd920ee 
  ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/repos/repoinfo.xml 296dcd5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/repos/repoinfo.xml b7424e0 
  ambari-server/src/main/resources/stacks/HDP/2.0/repos/repoinfo.xml 4c5ce1d 
  ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/repos/repoinfo.xml 61d086f 
  ambari-server/src/main/resources/stacks/HDP/2.1/repos/repoinfo.xml 7ea93c2 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
71bc1f8 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/UpdatePersistenceManagerTest.java
b60680c 
  ambari-server/src/test/python/TestOSCheck.py 8985fdc 
  ambari-server/src/test/resources/stacks/HDP/0.1/repos/repoinfo.xml 199710f 
  ambari-server/src/test/resources/stacks/HDP/0.2/repos/repoinfo.xml 4af41ae 
  ambari-server/src/test/resources/stacks/HDP/1.2.0/repos/repoinfo.xml 7c3b691 
  ambari-server/src/test/resources/stacks/HDP/1.3.0/repos/repoinfo.xml cff983a 
  ambari-server/src/test/resources/stacks/HDP/1.3.1/repos/repoinfo.xml f5c0fee 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/repos/repoinfo.xml d429a85 
  ambari-server/src/test/resources/stacks/HDP/2.0.5/repos/repoinfo.xml 7925e9e 
  ambari-server/src/test/resources/stacks/HDP/2.0.6/repos/repoinfo.xml 5c5d414 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/repos/repoinfo.xml 0799343 
  ambari-server/src/test/resources/stacks/HDP/2.0.8/repos/repoinfo.xml 1025240 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/repos/repoinfo.xml 44ca5c8 

Diff: https://reviews.apache.org/r/22972/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message