ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Baranchuk" <abaranc...@hortonworks.com>
Subject Re: Review Request 22954: Get sql metrics logic should be reviewed
Date Wed, 25 Jun 2014 15:37:06 GMT


> On June 25, 2014, 2:06 p.m., Tom Beerbower wrote:
> > Hi Artem, could you give some background on what this patch is doing?  Is this a
performance enhancement?  Thanks.

Yes Tom, this is performance patch. We need to do getting metrics by single sql query.
According to testing it improves performance ~2 times


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22954/#review46621
-----------------------------------------------------------


On June 25, 2014, 12:33 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22954/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 12:33 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
> 
> 
> Bugs: AMBARI-6266
>     https://issues.apache.org/jira/browse/AMBARI-6266
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Get sql metrics logic should be reviewed
> 
> 
> Diffs
> -----
> 
>   contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLPropertyProvider.java
49508ea 
>   contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/SQLPropertyProviderTest.java
d0298f3 
> 
> Diff: https://reviews.apache.org/r/22954/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34.066s
> [INFO] Finished at: Wed Jun 25 15:14:37 EEST 2014
> [INFO] Final Memory: 37M/257M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message