ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 22855: AMBARI-6233. Add Service wizard reverts core-site and global to stack default
Date Wed, 25 Jun 2014 02:51:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22855/
-----------------------------------------------------------

(Updated June 25, 2014, 2:51 a.m.)


Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Changes
-------

Changed the reConfigure Mixin to have all the previously declared private function nested
in the reconfigure function. 


Bugs: AMBARI-6233
    https://issues.apache.org/jira/browse/AMBARI-6233


Repository: ambari


Description
-------

This issue was initially noted while adding a service with NameNode HA enabled. This reverted
all NameNode HA configs in core-site. 
Then it was discovered while debugging that global and core-site configs are prepared in it's
entirety from stack and applied while adding any service. 
ambari-web should add new configs to core-siet and global but persist whatever was saved for
core-site and global before while adding a service.


Diffs (updated)
-----

  ambari-web/app/controllers/main/admin/security/security_progress_controller.js 1fc290a 
  ambari-web/app/controllers/wizard/step8_controller.js ca25817 
  ambari-web/app/mixins.js e8a89a8 
  ambari-web/app/mixins/common/reConfigure.js PRE-CREATION 
  ambari-web/app/utils/ajax/ajax.js 975e3c7 

Diff: https://reviews.apache.org/r/22855/diff/


Testing
-------

tested e2e for installer, Add service and Add host wizard.


Thanks,

Jaimin Jetly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message