ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 22940: Return field host_components fully when hosts filtered (Hosts table's filtering by Host Components won't work without this)
Date Tue, 24 Jun 2014 20:09:27 GMT


> On June 24, 2014, 6:58 p.m., Tom Beerbower wrote:
> > Just so I understand... does removing this block of code give us the behavior that
we want while still allowing for sub-resource queries or are we basically removing sub-resource
queries as a feature?

Yes. By patching we disable filtering sub-resources before providing response. But still allow
queries with predicates using sub-resources


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22940/#review46566
-----------------------------------------------------------


On June 24, 2014, 6:03 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22940/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 6:03 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Tom Beerbower.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Follow request:
> {noformat}
> /api/v1/clusters/<cluster-name>/hosts?host_components/HostRoles/component_name.in(<component-names>)&fields=host_components
> {noformat}
> should return host_components field with all host-components on the host, not just ones
that in filter.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 63426cb

>   ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java ad453d9

> 
> Diff: https://reviews.apache.org/r/22940/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [1.632s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
> [INFO] Ambari Web ........................................ SUCCESS [22.921s]
> [INFO] Ambari Views ...................................... SUCCESS [1.546s]
> [INFO] Ambari Server ..................................... SUCCESS [14:21.956s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.150s]
> [INFO] Ambari Client ..................................... SUCCESS [0.035s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.291s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [8.195s]
> [INFO] Ambari Shell ...................................... SUCCESS [4.434s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message