ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 22634: Blueprint validation fails when dependency is deployed to multiple host groups
Date Mon, 16 Jun 2014 18:07:37 GMT


> On June 16, 2014, 4:22 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java,
lines 1028-1030
> > <https://reviews.apache.org/r/22634/diff/2/?file=610698#file610698line1028>
> >
> >     Does ALL count too?
> 
> John Speidel wrote:
>     Valid point.  Even though this method currently isn't called if cardinality == ALL,
we do support auto-install for ALL so it should be reflected in this method.

Incorporated into latest patch


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22634/#review45766
-----------------------------------------------------------


On June 16, 2014, 4:19 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22634/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 4:19 p.m.)
> 
> 
> Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-6135
>     https://issues.apache.org/jira/browse/AMBARI-6135
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When a component has a specified dependency and the number of instances of the component
in the blueprint > 1, blueprint validation fails. An example of this is multiple ZK server
instances and any component such as Nimbus being deployed which has a dependency on ZOOKEEPER_SERVER.
Because there are 3 ZK server instances, the dependency should be satisfied but validation
fails.
> 
> This occurs because when we check that a dependency exists, we were looking for a count
of 1 for cluster scoped dependencies instead of 1+.
> 
> See bug for more info.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java
c6995f4 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
d04f24f 
> 
> Diff: https://reviews.apache.org/r/22634/diff/
> 
> 
> Testing
> -------
> 
> Functional Testing:
> Registered blueprint specified in associated Jira.
> 
> Unit Tests:
> New unit test added
> All existing unit tests pass
> 
> Results :
> 
> Tests run: 1672, Failures: 0, Errors: 0, Skipped: 13
> ...
> Total run:572
> Total errors:0
> Total failures:0
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:08.929s
> [INFO] Finished at: Mon Jun 16 11:45:51 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message