ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 22536: Customize the Hadoop metrics sink to write to MySQL store
Date Fri, 13 Jun 2014 21:26:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22536/#review45657
-----------------------------------------------------------



contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/SqlSink.java
<https://reviews.apache.org/r/22536/#comment80561>

    Would it be possible to get rid of DbType and just make the code that uses it abstract
in SqlSink?  Then implement that stuff specific to the DbType in the concrete classes.  That
way the base class doesn't need to know anything about specific DB types.


- Tom Beerbower


On June 13, 2014, 9:17 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22536/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 9:17 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Tom Beerbower.
> 
> 
> Bugs: AMBARI-6106
>     https://issues.apache.org/jira/browse/AMBARI-6106
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The SqlServerSink should support pushing metrics to MySQL store.
> 
> This Jira addresses changes needed to support sink to a MySQL store.
> 
> 
> Diffs
> -----
> 
>   contrib/ambari-scom/contrib/ambari-scom/metrics-sink/db/Hadoop-Metrics-MySQL-CREATE.ddl
PRE-CREATION 
>   contrib/ambari-scom/metrics-sink/db/Hadoop-Metrics-MySQL-CREATE.ddl PRE-CREATION 
>   contrib/ambari-scom/metrics-sink/db/Hadoop-Metrics-SQLServer-CREATE.ddl b0ee7b7 
>   contrib/ambari-scom/metrics-sink/pom.xml 7c2706a 
>   contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/MySqlSink.java
PRE-CREATION 
>   contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/MySqlSinkHadoop1.java
PRE-CREATION 
>   contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/MySqlSinkHadoop2.java
PRE-CREATION 
>   contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/SqlServerSink.java
3e5b70c 
>   contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/SqlServerSinkHadoop1.java
852fb81 
>   contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/SqlServerSinkHadoop2.java
eae76a8 
>   contrib/ambari-scom/metrics-sink/src/main/java/org/apache/hadoop/metrics2/sink/SqlSink.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22536/diff/
> 
> 
> Testing
> -------
> 
> Results :
> 
> Tests run: 80, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message