ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 22317: Flume: API returns agents info even after it was removed
Date Tue, 10 Jun 2014 10:23:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22317/#review45212
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py
<https://reviews.apache.org/r/22317/#comment79937>

    We use to mock all things from os like that in testcases, just to be safe and platform
free.



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py
<https://reviews.apache.org/r/22317/#comment79938>

    Just for note in other scripts we reimported params , rather than passed as a parameter
(guess a bit easier to read), and it should take the same time since it's not imported second
time it's just takes the pointer. 
    Not a big deal though.
    
    Also can we name this more clear. Find excepted WHAT? find_expected_meta_files Maybe like
thiS?


- Andrew Onischuk


On June 6, 2014, 8:45 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22317/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 8:45 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
> 
> 
> Bugs: AMBARI-6055
>     https://issues.apache.org/jira/browse/AMBARI-6055
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change the flume script to cleanup left-over flume meta-files that are no longer tracked
by Ambari
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py
b227f53 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 0d8ebd5 
> 
> Diff: https://reviews.apache.org/r/22317/diff/
> 
> 
> Testing
> -------
> 
> Stack changes only.  Updated test scripts and verified on a running cluster.
> 
> OK
> ----------------------------------------------------------------------
> Total run:564
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message