ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Florian Barca" <fba...@hortonworks.com>
Subject Re: Review Request 22271: ZK should not be required to be restarted after adding a host
Date Fri, 06 Jun 2014 18:40:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22271/
-----------------------------------------------------------

(Updated June 6, 2014, 6:40 p.m.)


Review request for Ambari, Dmytro Sen, Jonathan Hurley, and Mahadev Konar.


Changes
-------

Updated patch to reflect the latest branch changes. Removed the parasitic changes that sneaked
in the previous patch.


Bugs: AMBARI-6039
    https://issues.apache.org/jira/browse/AMBARI-6039


Repository: ambari


Description
-------

Added a filtering layer by host name. When adding a host, this is the new host name, which
is not yet available in the configuration, so the filtering avoids setting the stale flag
on the applicable services.

Remarks:
- The code gets called whenever we add a host, including at cluster setup time. Didn't notice
a change in behavior though.
- The code is trying to cover all the possible situations with one general approach. There
is a potential for future bugs due to new services' potentially different behavior.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
1297f6c 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
5cf5986 

Diff: https://reviews.apache.org/r/22271/diff/


Testing
-------

Unit test code added in the existing test case. Also, ran the end-to-end test on the local
cluster and confirmed that the ZK service does not appear stale after adding a host to the
existing configuration.


Thanks,

Florian Barca


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message