ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 22227: Hosts API should provide count of filtered hosts
Date Thu, 05 Jun 2014 10:03:48 GMT


> On June 4, 2014, 3:54 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java,
line 541
> > <https://reviews.apache.org/r/22227/diff/1/?file=603330#file603330line541>
> >
> >     Wrong type in javadoc.

Committed 1-line fix


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22227/#review44717
-----------------------------------------------------------


On June 4, 2014, 12:04 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22227/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 12:04 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-5981
>     https://issues.apache.org/jira/browse/AMBARI-5981
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Additional patch.
> 
> We need the number of filtered hosts in response of query to Hosts API.
> The number should be affected by all filter properties, except "from" and "page_size".
> For example,
> following query:
> {noformat}
> /api/v1/clusters/c/hosts?from=0&page_size=25&Hosts/host_name.matches(host.*)
> {noformat}
> should return number of filtered hosts by host_name, but ignoring "from" and "page_size"
parameters.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java
a54b303 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java
4458799 
> 
> Diff: https://reviews.apache.org/r/22227/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [2.385s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.437s]
> [INFO] Ambari Web ........................................ SUCCESS [10.426s]
> [INFO] Ambari Views ...................................... SUCCESS [1.739s]
> [INFO] Ambari Server ..................................... SUCCESS [13:30.766s]
> [INFO] Ambari Agent ...................................... SUCCESS [5.973s]
> [INFO] Ambari Client ..................................... SUCCESS [0.029s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.252s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [2.506s]
> [INFO] Ambari Shell ...................................... SUCCESS [3.971s]
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message