ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 22153: Race condition when starting all services causing Hive service check to fail
Date Wed, 04 Jun 2014 17:05:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22153/
-----------------------------------------------------------

(Updated June 4, 2014, 1:05 p.m.)


Review request for Ambari, Nate Cole and Sid Wagle.


Bugs: AMBARI-5800
    https://issues.apache.org/jira/browse/AMBARI-5800


Repository: ambari


Description
-------

The Hive server start check only looks for a PID when returning a successful starting condition.
Although the Hive service check depends on the server starting, the server might not be up
and running even though the PID exists.

This changes the Hive start scripts to ensure they do not return a success until the server
because active and the connection port is open.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/hive_service.py
568f6ec 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_service.py
596eec9 
  ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 6cd9f52 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py cec393a 

Diff: https://reviews.apache.org/r/22153/diff/


Testing (updated)
-------

Updated unit tests to cover the socket.close() function.

----------------------------------------------------------------------
Total run:563
Total errors:0
Total failures:0
OK

Manually verified Fail(...) message in logs:

Fail: Connection to Hive server c6402.ambari.apache.org on port 10000 failed after 120 seconds


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message