ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 22029: Some HBase properties are empty, but required to be filled
Date Wed, 04 Jun 2014 05:05:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22029/#review44690
-----------------------------------------------------------

Ship it!


Ship It!

- Jaimin Jetly


On June 3, 2014, 1:06 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22029/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 1:06 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-5930
>     https://issues.apache.org/jira/browse/AMBARI-5930
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When using a blueprint to create a cluster, there are two HBase properties that are flagged
as required, but empty. Since these are custom classes, the fact that they are empty is probably
correct (they've been empty in our stack model since the beginning of time).
> 
> However, the web client code flags them as "isRequired" even though the site_properties.js
defines them as isRequired : false
> 
> The web client code was assuming a value of "true" even if the stack definition object
said they were false. The solution was to check to see if that value is defined in the stack
object first, and use that value.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/utils/config.js eb6febc 
> 
> Diff: https://reviews.apache.org/r/22029/diff/
> 
> 
> Testing
> -------
> 
> hw10897:ambari-web jhurley$ mvn test
> ...
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 10.019s
> [INFO] Finished at: Thu May 29 14:58:47 EDT 2014
> [INFO] Final Memory: 6M/81M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message